Improve error-handling

ciscoconfparse/ccp_abc.py

@@ -23,7 +23,7 @@
 import inspect
 import re
 
-from ciscoconfparse.errors import InvalidTypecast
+from ciscoconfparse.errors import InvalidTypecast, InvalidParameters
 from ciscoconfparse.ccp_util import junos_unsupported
 from loguru import logger
 
@@ -292,7 +292,10 @@ def text(self):
     def text(self, newtext=None):
         """Set self.text, self.indent, self.line_id (and all comments' self.parent)"""
         # FIXME - children do not associate correctly if this is used as-is...
-        assert isinstance(newtext, str)
+        if not isinstance(newtext, str):
+            error = f"text=`{newtext}` is an invalid config line"
+            error.critical(error)
+            raise InvalidParameters(error)
 
         # escape braces since single braces could be misunderstood as
         # f-string or string.format() delimiters...

ciscoconfparse/ciscoconfparse.py

@@ -402,7 +402,7 @@ def _cfgobj_from_text(
         )
 
     # if factory is **faster** than if factory is True
-    elif factory:
+    elif syntax in ALL_VALID_SYNTAX and factory:
         obj = ConfigLineFactory(
             txt,
             comment_delimiter,
@@ -411,8 +411,7 @@ def _cfgobj_from_text(
 
     else:
         err_txt = (
-            "Cannot classify config list item '%s' "
-            "into a proper configuration object line" % txt
+            f"Cannot classify config list item `{txt}` into a proper configuration object line"
         )
         logger.error(err_txt)
         raise ValueError(err_txt)