feat: Add User Filtering to Kit #9
Conversation
alexs-mparticle
requested review from
BrandonStalnaker,
Mansi-mParticle and
rmi22186
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
looks good. mostly nits. tests?
src/Rokt-Kit.js
Outdated
| service, | ||
| testMode, | ||
| trackerId, | ||
| _userAttributes |
There was a problem hiding this comment.
let's label this filteredUserAttributes so it's distinct (and that's what it is regardless of what this was originally named)
| _userAttributes | |
| filteredUserAttributes |
src/Rokt-Kit.js
Outdated
| self.filters = window.mParticle.Rokt.filters; | ||
|
|
||
| // Attaches the launcher and kit to the Rokt manager | ||
| window.mParticle.Rokt.attachLauncher(launcher); |
There was a problem hiding this comment.
we don't need to attach the launcher anymore here. instead it should still notify mParticle.Rokt that it is now available and the rokt kit is ready so that the core sdk can fire of the queued events
There was a problem hiding this comment.
seems like when you attach the kit it then calls processMessageQueue on the core SDK, so i think this is fine and we can remove attachLauncher completely.
src/Rokt-Kit.js
Outdated
|
|
||
| function selectPlacements(options) { | ||
| var attributes = (options && options.attributes) || {}; | ||
| var placementAttributes = mergeObjects(attributes, self.userAttributes); |
There was a problem hiding this comment.
i would flip these, so that the attributes passed in from the customer override anything we have cached.
alexs-mparticle
force-pushed
the
feat/SQDSDKS-7159-user-filtering
branch
from
63f464b to
a791b35
Compare
4 participants
Summary
Add User Filtering logic to Rokt Kit
Testing Plan
window.mParticle.Rokt.selectPlacementthat have been filtered via the mParticle UI and verify the filtered attributes are not passed through.