fix: Reduce Rokt Kit Bundle Size #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisryantan
approved these changes
Mar 13, 2025
rmi22186
reviewed
Mar 13, 2025
package.json
Outdated
| "name": "@mparticle/web-rokt-wsdk-kit", | ||
| "version": "0.0.2", | ||
| "main": "dist/RoktWsdk-Kit.common.js", | ||
| "description": "mParticle integration sdk for Rokt", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "description": "mParticle integration sdk for Rokt", | |
| "description": "mParticle integration kit for Rokt", |
rmi22186
reviewed
Mar 13, 2025
package.json
Outdated
| "main": "dist/Rokt-Kit.common.js", | ||
| "files": [ | ||
| "dist/RoktWsdk-Kit.common.js" | ||
| "dist/Rokt-Kit.common.js" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "dist/Rokt-Kit.common.js" | |
| "dist/Rokt-Kit.common.js", | |
| "dist/Rokt-Kit.iife.js" |
rmi22186
reviewed
Mar 13, 2025
package.json
Outdated
| @@ -1,26 +1,25 @@ | |||
| { | |||
| "name": "@mparticle/web-rokt-wsdk-kit", | |||
Collaborator
There was a problem hiding this comment.
i'd proposing dropping the wsdk, as this aligns with our other kits
rmi22186
reviewed
Mar 13, 2025
src/Rokt-Kit.js
Outdated
| } | ||
|
|
||
| function register(config) { | ||
| var forwarderNameWithSuffix = [name, suffix].join('-'); |
Collaborator
There was a problem hiding this comment.
i'd get rid of any information regarding suffix since suffix doesn't exist. braze is in a special category. you can pull code in this register section from anther pre-integration builder that doesn't have suffix, like amplitude
rmi22186
requested changes
Mar 13, 2025
Collaborator
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
left some fairly simple comments
Co-authored-by: Robert Ing <[email protected]>
rmi22186
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan