fix: Correct isInitialized check in hashAttributes and setExtensionData functions#39
Merged
alexs-mparticle merged 4 commits intodevelopmentfrom Aug 12, 2025
Merged
Conversation
alexs-mparticle
requested review from
Copilot and
rmi22186
and removed request for
rmi22186
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect function call check by removing parentheses from isInitialized() calls in two functions, changing them from function invocations to property access.
- Corrects the
isInitializedcheck inhashAttributesfunction fromisInitialized()toisInitialized - Corrects the
isInitializedcheck insetExtensionDatafunction fromisInitialized()toisInitialized
rmi22186
reviewed
Aug 7, 2025
rmi22186
reviewed
Aug 7, 2025
rmi22186
requested changes
Aug 7, 2025
Collaborator
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
Code looks fine. My concern is more about the tests.
Co-authored-by: Robert Ing <ring@mparticle.com>
rmi22186
approved these changes
Aug 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
## [1.6.3](v1.6.2...v1.6.3) (2025-08-12) ### Bug Fixes * Correct isInitialized check in hashAttributes and setExtensionData functions ([#39](#39)) ([3a13833](3a13833))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{provide a thorough description of the changes}
isInitializedTesting Plan
{explain how this has been tested, and what additional testing should be done}
hashAttributesorsetExtensionData.