Skip to content

fix: Improve error handling and user attribute filtering in Rokt Kit#18

Merged
alexs-mparticle merged 2 commits intodevelopmentfrom
fix/e2e-testing-filters
Apr 2, 2025
Merged

fix: Improve error handling and user attribute filtering in Rokt Kit#18
alexs-mparticle merged 2 commits intodevelopmentfrom
fix/e2e-testing-filters

Conversation

@alexs-mparticle
Copy link
Collaborator

Summary

  • Adds some protection around filters and filtered users

Testing Plan

  • Use a sample app to verify interactions with filtered users

@alexs-mparticle alexs-mparticle requested review from Copilot and rmi22186 and removed request for Copilot April 1, 2025 20:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling and validates the availability of functions and filters around user attributes in Rokt Kit.

  • Removed the catch block from the attachLauncher call to potentially delegate error handling to a higher level.
  • Added protection for accessing filterUserAttributes and provided fallback warnings for missing filters.
  • Enhanced the assignment of filters by verifying the existence of the Rokt filters before using them.
Comments suppressed due to low confidence (1)

src/Rokt-Kit.js:65

  • Removing the catch block may lead to unhandled promise rejections if attachLauncher fails; consider adding error handling or verifying that errors are caught at a higher level.
attachLauncher(accountId, sandboxMode);

@alexs-mparticle alexs-mparticle merged commit 8da2176 into development Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants