fix: Improve error handling and user attribute filtering in Rokt Kit#18
Merged
alexs-mparticle merged 2 commits intodevelopmentfrom Apr 2, 2025
Merged
fix: Improve error handling and user attribute filtering in Rokt Kit#18alexs-mparticle merged 2 commits intodevelopmentfrom
alexs-mparticle merged 2 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling and validates the availability of functions and filters around user attributes in Rokt Kit.
- Removed the catch block from the attachLauncher call to potentially delegate error handling to a higher level.
- Added protection for accessing filterUserAttributes and provided fallback warnings for missing filters.
- Enhanced the assignment of filters by verifying the existence of the Rokt filters before using them.
Comments suppressed due to low confidence (1)
src/Rokt-Kit.js:65
- Removing the catch block may lead to unhandled promise rejections if attachLauncher fails; consider adding error handling or verifying that errors are caught at a higher level.
attachLauncher(accountId, sandboxMode);
rmi22186
reviewed
Apr 1, 2025
rmi22186
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan