feat: replace sandboxMode check with mParticle.getEnvironment()#12
Merged
alexs-mparticle merged 4 commits intodevelopmentfrom Mar 27, 2025
Merged
Conversation
1 task
Contributor
Author
|
Disclaimer. Do not merge this until mParticle/mparticle-web-sdk#1009 is merged and |
rmi22186
requested changes
Mar 26, 2025
Collaborator
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
A couple things - we use an automated release process, and haven't cut a version yet, but there isn't a need to update the versions in package-lock.json nor package.json. i'd also cut the branch off of development and PR into that, not main.
crisryantan
force-pushed
the
feat/NI-742-remove-reference-to-sandbox
branch
from
2e0d40c to
639f9ab
Compare
crisryantan
changed the title
rmi22186
approved these changes
Mar 27, 2025
rmi22186
reviewed
Mar 27, 2025
Co-authored-by: Robert Ing <ring@mparticle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/Rokt-Kit.jsTesting Plan