Optimize shape handling in PyMuPdfRenderBackend #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each drawing operation previously created and committed a new shape, causing significant performance overhead. This update introduces a shared shape instance reused across operations and committed once in finalize(). This change was inspired by a suggestion from the PyMuPDF maintainer in pymupdf/PyMuPDF#3800. Performance improvements can exceed 100x in documents with many entities.
Owner
|
Thank you!
|
Owner
|
I was wrong, the size of the new PDFs is also smaller! In average: 38x faster and 2.5x smaller!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each drawing operation previously created and committed a new shape, causing significant performance overhead. This update introduces a shared shape instance reused across operations and committed once in finalize().
This change was inspired by a suggestion from the PyMuPDF maintainer in pymupdf/PyMuPDF#3800. Performance improvements can exceed 100x in documents with many entities.