Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3897: add admin check for actions #5573

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

MNTOR-3897: add admin check for actions #5573

wants to merge 5 commits into from

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Jan 30, 2025

References:

Jira: MNTOR-3897

Description

Add admin checks for churn dash actions

Checklist (Definition of Done)

@mansaj mansaj requested a review from rhelmer January 30, 2025 21:38
Copy link

Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned a few things, the only important one is that from the NextJS docs, I believe that returning null is the right thing to do for now (but note there's an experimental forbidden handler which will be available eventually)

@mansaj mansaj requested a review from rhelmer February 1, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants