Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: RTL audit and fixes #15742

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Refresh: RTL audit and fixes #15742

merged 1 commit into from
Dec 17, 2024

Conversation

stephaniehobson
Copy link
Contributor

One-line summary

RTL audit and fixes

Significant changes and points to review

  • Don't use our fonts in Arabic
  • Animate the line under CTAs in the reverse direction for RTL
  • Alignment fixes

Issue / Bugzilla link

#15416

Testing

@stephaniehobson stephaniehobson marked this pull request as ready for review December 16, 2024 23:13
@stephaniehobson stephaniehobson requested a review from a team as a code owner December 16, 2024 23:13
@stephaniehobson stephaniehobson added Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Dec 16, 2024
@maureenlholland maureenlholland self-assigned this Dec 17, 2024
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🟢

@@ -46,7 +46,7 @@

.m24-c-careers-cta {
margin-top: $spacer-lg;
text-align: right;
text-align: end;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 logical properties are great

@maureenlholland maureenlholland merged commit e156a40 into main Dec 17, 2024
5 checks passed
@maureenlholland maureenlholland deleted the m24-rtl branch December 17, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants