Support long locale in dynamic served js catalog #23006
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
requested review from
a team and
diox
and removed request for
a team
diox
reviewed
Jan 22, 2025
KevinMind
force-pushed
the
kevinmind/15297
branch
2 times, most recently
from
3ff4dea to
13adf48
Compare
KevinMind
force-pushed
the
kevinmind/15297
branch
from
13adf48 to
5d31a46
Compare
diox
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15297
Description
Support long locale for serving dynamic i18n bundles
Context
This problem was pre-existing and only short locales were covered with tests.
It surfaced when we landed PR that redireected short locale to long locale default.
Testing
clean the ./static and ./site-static directories to ensure no compiled locales exist.
run dev mode "make up"
Ensure devhub loads and the locale file en-US.js is loaded 200.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.