Make reviewer pending rejection input a datetime widget and allow changing it through an action #23001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
commented
Jan 20, 2025
| methods=['post'], | ||
| permission_classes=[GroupPermission(amo.permissions.REVIEWS_ADMIN)], | ||
| ) | ||
| def clear_pending_rejections(self, request, **kwargs): |
There was a problem hiding this comment.
Drive-by cleanup to reduce confusion - This API was already obsolete since 9f1e462
…nging it through an action
diox
force-pushed
the
change-pending-rejection
branch
from
e99835a to
dbcb1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#14920
Description
This allows reviewers to change the pending rejection date of versions pending rejection through a widget where they can select the date and time.
Because the actions menu is already pretty large, the clear pending rejection date action is reused, with an option to change or clear ; to tie everything together and make the UI more consistent, the rejection action use the same widgets, making the date choice absolute rather than relative.
Screenshots
New reject multiple versions UI
Modified Clear pending rejection action (now Change pending rejection) UI
Testing
See tests. Non-exhaustive list of scenarios, after submitting an add-on and going to its review page:
Changing the delay (not clearing it) should send an email to the developer following copy that can be found as a comment in the issue.
Changing a delay should require the new date to be at least one extra day in the future compared to now. Changing the delay of multiple versions at once is possible, but the existing pending rejection date should all be the same.