Skip to content

Commit

Permalink
Don't show duplicate flags for NeedsHumanReview reasons already flagg…
Browse files Browse the repository at this point in the history
…ed explicitly (#22900)

Those new NeedsHumanReview reasons get a flag because they are in VIEW_QUEUE_FLAGS.
That is useful for the form to filter the queue for those reasons, but they don't
need to show the corresponding sprite icon, because we also already display one by
checking AddonReviewerFlags/PromotedAddon state.
  • Loading branch information
diox committed Nov 28, 2024
1 parent 02bb35c commit b4aa71f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion static/css/zamboni/reviewers.less
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
.ed-sprite-needs-human-review-from-abuse { background-position: 0 -468px; }
.ed-sprite-needs-human-review-from-cinder { background-position: 0 -484px; }
.ed-sprite-needs-human-review-from-appeal { background-position: 0 -500px; }
/* Those NeedsHumanReview reasons are already handled through separate, more
precise flags, so hide them */
.ed-sprite-needs-human-review-promoted { display: none; }
.ed-sprite-needs-human-review-auto-approval-disabled { display: none; }
.ed-sprite-is-from-theme-awaiting-review { display: none; }

.ed-sprite-action-target-Extension { background-position: 0 -532px; }
.ed-sprite-action-target-Theme { background-position: 0 -564px; }
Expand Down Expand Up @@ -1428,4 +1433,4 @@ table.abuse_reports {
.review-actions-attachment-reply {
display: flex;
flex-direction: column;
}
}

0 comments on commit b4aa71f

Please sign in to comment.