Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output list instead of table #5426

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

fregante
Copy link
Contributor

Before

This isn't even the full table, it doesn't fit on my screen

Screenshot 3

After

Screenshot 2

out.push(` ${location}`);
});
out.push('');
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand @rpl This code is straight out of Claude. We can bikeshed the output but I think it's a vast improvement already.

Codebase cleanup and tests update will follow after approval

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been good to discuss in #5423 first. I don't really have a strong opinion on the current linter output but - at the same time - this works relatively well and that isn't necessarily an area where I'd change code, but that's my personal opinion on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a PR right after the issue in order to demo the output and changes required. It's always easier to discuss things when there's an exact desired output, especially in a project that evolves very slowly.

@fregante
Copy link
Contributor Author

fregante commented Jan 3, 2025

@rpl @willdurand I believe the improvements here are evident from my screenshots:

  • the output is shorter
  • there's no duplicate explanation
    Screenshot 3
  • there's no bad wrapping of long text
    Screenshot 2
  • paths are always clickable
    Screenshot 4
  • row and col are part of the path, meaning IDEs can reach them in the same click
    Screenshot
  • the table implementation isn't even right because the error/warning tables are not aligned
    Screenshot

The only reason not to move forward with this is because it already works, albeit in this suboptimal fashion. Since I'm currently available to work on this, allow me to complete this change and merge this PR. I don’t really like keeping PRs open for years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output as list, not table
2 participants