[HNT-295] fix section date localization #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmiermans
commented
Dec 18, 2024
| ScheduledSurfaceId.NEW_TAB_ES_ES: "es_ES", | ||
| ScheduledSurfaceId.NEW_TAB_IT_IT: "it_IT", | ||
| ScheduledSurfaceId.NEW_TAB_EN_INTL: "en_IN", # En-Intl is primarily used in India. | ||
| } |
There was a problem hiding this comment.
The section experiment only runs in the US and Germany, but I thought it was better to implement this for all markets that we serve.
| Returns: | ||
| str: Localized date string, for example "December 17, 2024". | ||
| """ | ||
| return format_date(date, format="long", locale=SURFACE_ID_TO_LOCALE.get(surface_id, "en_US")) |
There was a problem hiding this comment.
just confirming that this defaults to en-US?
katerinachinnappan
approved these changes
Jan 9, 2025
mmiermans
changed the title
|
Closing this because it was decided to remove 'In the News', and we therefore don't need to localize dates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: HNT-295
Description
The date in the subtitle of the 'In the News' section is localized based on the
ScheduledSurfaceId.PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)