non-capturama requests notify iframe parent via postMessage; prettify #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchesler
reviewed
Jul 11, 2018
src/cropduster.js
Outdated
| @@ -199,29 +223,34 @@ const CD = { | |||
|
|
|||
| CD.pause(options.maxSuspension || 0, msg); | |||
There was a problem hiding this comment.
Why not rename this msg as well? (declared on line 216 above, but github won't let me put my comment up there)
mchesler
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports a subsequent change in the MDK Live Preview to notify on events such as failed crops. We do this by having cropduster call
window.postMessage()in addition to whatever other capturama API it uses.Additionally, renames the
msgvariables tomessagefor clarity and prettifies.What this will eventually get us: