[sc-102435] Bump and pin faraday + update gemfile.lock #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #102435: [OnCall] 2024-01-03 to 2024-01-10. |
rayrod2030
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
faradayis not pinned as a runtime dependency, leading to installing "latest" every time. Today version2.9was released that has a dependency that does not support Ruby 2.6 (faraday-net_httpversion3.1.0).Why do we need this change?
Need to pin a supported version of
faradayand its dependencies.Implementation Details
faradayversion2.8.1as a runtime dependency, which comes with supportedfaraday-net_httpversion3.0.2Dependencies (if any)
🏠 sc-102435