feat: deprecate py3.8 (#602)

* feat: deprecate py3.8 Signed-off-by: Keming <[email protected]> * bump version Signed-off-by: Keming <[email protected]> --------- Signed-off-by: Keming <[email protected]>
mosecorg · Nov 26, 2024 · f4f58ec · f4f58ec
1 parent d0f9cb7
commit f4f58ec
Show file tree

Hide file tree

Showing 11 changed files with 84 additions and 91 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -43,7 +43,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install dependencies
         run: make install
       - name: install node for pyright
@@ -61,11 +61,9 @@ jobs:
     strategy:
       max-parallel: 18
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         os: [ubuntu-latest , macos-13, macos-14]
         exclude:
-          - python-version: "3.8"
-            os: "macos-14"
           - python-version: "3.9"
             os: "macos-14"
 

diff --git a/.github/workflows/page.yml b/.github/workflows/page.yml
@@ -34,10 +34,10 @@ jobs:
         fetch-depth: 0
     - name: Setup Pages
       uses: actions/configure-pages@v5
-    - name: Set up Python 3.8
+    - name: Set up Python
       uses: actions/setup-python@v5
       with:
-        python-version: 3.8
+        python-version: 3.9
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/examples/rerank/server.py b/examples/rerank/server.py
@@ -16,7 +16,7 @@
 from typing import List
 
 from msgspec import Struct
-from sentence_transformers import CrossEncoder
+from sentence_transformers import CrossEncoder  # type: ignore
 
 from mosec import Server, Worker
 from mosec.mixin import TypedMsgPackMixin

diff --git a/examples/server_side_event/client.py b/examples/server_side_event/client.py
@@ -15,15 +15,21 @@
 import httpx
 from httpx_sse import connect_sse
 
-with httpx.Client() as client, connect_sse(
-    client, "POST", "http://127.0.0.1:8000/inference", json={"text": "mosec"}
-) as event_source:
+with (
+    httpx.Client() as client,
+    connect_sse(
+        client, "POST", "http://127.0.0.1:8000/inference", json={"text": "mosec"}
+    ) as event_source,
+):
     for sse in event_source.iter_sse():
         print(f"Event({sse.event}): {sse.data}")
 
 # error handling
-with httpx.Client() as client, connect_sse(
-    client, "POST", "http://127.0.0.1:8000/inference", json={"error": "mosec"}
-) as event_source:
+with (
+    httpx.Client() as client,
+    connect_sse(
+        client, "POST", "http://127.0.0.1:8000/inference", json={"error": "mosec"}
+    ) as event_source,
+):
     for sse in event_source.iter_sse():
         print(f"Event({sse.event}): {sse.data}")