Skip to content

Types #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robertsLando wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Types #48

robertsLando wants to merge 1 commit into from

Conversation

@robertsLando
Copy link
Member

@robertsLando robertsLando commented Feb 24, 2020

No description provided.

@robertsLando robertsLando requested a review from gnought February 24, 2020 10:12
@robertsLando
Copy link
Member Author

robertsLando commented Feb 24, 2020

Tests will be fixed after merging #47

@robertsLando robertsLando mentioned this pull request Feb 24, 2020
Closed
mcollina
mcollina requested changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests for the types

@gnought
Copy link
Collaborator

gnought commented Feb 24, 2020

Hold a bit, I’m also working on it.
I’ll update some changes in this PR branch

@robertsLando
Copy link
Member Author

robertsLando commented Feb 24, 2020

@gnought Ok I leave this to you so :)

@robertsLando
Copy link
Member Author

robertsLando commented Feb 24, 2020

@gnought Could you replace this .on with .once ? https://github.com/moscajs/aedes-persistence/blob/master/abstract.js#L42

@robertsLando
Copy link
Member Author

robertsLando commented Mar 23, 2020

@gnought ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina requested changes

@gnought gnought Awaiting requested review from gnought

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robertsLando @gnought @mcollina