Draft: add new payment method for Bacs debit #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7.x-2.x #35 +/- ##
=============================================
- Coverage 25.23% 24.35% -0.89%
- Complexity 136 145 +9
=============================================
Files 17 20 +3
Lines 840 891 +51
=============================================
+ Hits 212 217 +5
- Misses 628 674 +46
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incomplete draft implementation for bacs debit.
For the current code, Stripe responds with "Your account is not configured to allow passing mandate_data directly when confirming PaymentIntents for Bacs Direct Debits." Not quite sure what that means. Maybe a customer (with the bacs_debit method) needs to be created before attaching it to a setup intent?
Edit: The error has changed to "Your account is not configured to directly use SetupIntents to create Mandates for Bacs Direct Debits." when adding "bacs_debit" as payment method type to the setup intent. There is no way to configure anything for Bacs DD in the Stripe UI (except upgrading to a payed version to show your business name on bank statements) → requires a conversation with support ([email protected]).
Edit: The error occurs when
bacs_debitis in the list of 'payment_method_types' for a SetupIntent.Note:
confirmBacsDebitPayment()does not exists, can only be used with setup intents.