Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions to local_codechecker #131

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Jan 29, 2021

Also, fix a couple of warnings to allow checks to pass and
enable a check that was previously commented out in
travis awaiting us to have a new moodle-plugin-ci version
now released.

@stronk7
Copy link
Member Author

stronk7 commented Jan 30, 2021

Putting this on hold because it's passing for travis, but failing for gha (consistently 34 and 36 branches).

Needs investigation!

Edited: moodlehq/moodle-plugin-ci#79 created

Not much to say, using the recommended configuration
and the combinations already used by travis.

Also, fix a couple of warnings to allow checks to pass and
enable a check that was previously commented out in
travis awaiting us to have a new moodle-plugin-ci version
now released.

Finally, remove the 34_STABLE branch (travis & gha),
because it's causing some behat problems, not worth investigating.
@stronk7
Copy link
Member Author

stronk7 commented Feb 4, 2021

Sending again... moodle-plugin-ci new release (3.0.5) should allow us to pass here...

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks great and it's nice to see GitHub Actions will be supported now by the local_codechecker plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants