Marshal error with full context chain #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickng
commented
Nov 29, 2022
| @@ -235,6 +291,42 @@ var unmarshalTestCases = []struct { | |||
| Retryable: nil, | |||
| }, | |||
| }, | |||
| // Wrapped errors only gets unmarshaled as a single error | |||
There was a problem hiding this comment.
marshaling and unmarshaling are asymmetric to start with, but the error code is preserved.
Line 192 in ff4c482
When using the new `Augment` function to add context and wrap errors,
the error message in Go is chained and displayed with the full chain
of context:
```
err := InternalService("code", "message", nil)
augmentedErr := Augment(err, "context", nil)
// This is "internal_service.code: context: message"
augmentedErr.Error()
```
But the marshaled error only displays the first level of context,
i.e.
```
// This is just "context"
Marshal(augmentedErr.(*Error)).Message
```
This commit changes the Marshal behaviour to include the full context
chain of error, so it's actually useful outside of Go when marshaled.
```
// This is now "context: message"
Marshal(augmentedErr.(*Error)).Message
```
nickng
force-pushed
the
nickng-marshal-full-message
branch
from
ff4c482
to
2472e06
Compare
rubendura
reviewed
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new
Augmentfunction to add context and wrap errors, the error message in Go is chained and displayed with the full chain of context:But the marshaled error only displays the first level of context, i.e.
This commit changes the Marshal behaviour to include the full context chain of error, so it's actually useful outside of Go when marshaled.