Add tests for ToHarfBuzzBlob disposal behavior (#3466) #3467
+170
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add test coverage for PR #3466's behavioral change where
ToHarfBuzzBlobno longer disposes theSKStreamAssetparameter.Tests Added (6 methods in
SKShaperTest.cs)ToHarfBuzzBlobDoesNotDisposeStream- Stream remains accessible after blob creationToHarfBuzzBlobStreamMustBeDisposedByCaller- Validates caller disposal responsibilityToHarfBuzzBlobBlobCanBeUsedWithinStreamLifetime- Safe usage pattern:using (stream) using (blob)ToHarfBuzzBlobWorksWithNonMemoryMappedStream- Memory copy fallback path (whenGetMemoryBase()returns zero)SKShaperConstructorSucceeds- Integration test for SKShaper with new behaviorToHarfBuzzBlobCanCreateMultipleBlobsFromSameStream- Stream reusability validationTest Expectations
Current code (before #3466): Tests fail - blob incorrectly disposes stream via destroy callback
After #3466 merge: Tests pass - caller manages stream lifecycle
Bugs Fixed
None. (Test-only PR supporting #3466)
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)1k9vsblobprodcus379.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)1s1vsblobprodcus386.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)4myvsblobprodcus32.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)4vyvsblobprodcus361.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)7devsblobprodcus323.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)7k6vsblobprodcus337.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)c50vsblobprodcus330.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)c78vsblobprodcus322.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)cflvsblobprodcus383.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)frdvsblobprodcus327.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)jd4vsblobprodcus366.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)kh4vsblobprodcus325.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)l49vsblobprodcus358.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)l7avsblobprodcus319.vsblob.vsassets.io/usr/bin/dotnet dotnet tool restore(dns block)lylvsblobprodcus31.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)m6xvsblobprodcus342.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)pc2vsblobprodcus360.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)rcxvsblobprodcus328.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)u3hvsblobprodcus371.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)u6ovsblobprodcus377.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)uy6vsblobprodcus34.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)yluvsblobprodcus367.vsblob.vsassets.io/usr/bin/dotnet dotnet build tests/SkiaSharp.Tests.Console/SkiaSharp.Tests.Console.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.