fix: return 404 on missing assets (@fehmer) #7379
Open
+4
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
force-pushed
the
feature/serve-404-on-missing-assets
branch
from
535e29f to
891e1bb
Compare
fehmer
commented
Jan 16, 2026
fehmer
commented
Jan 16, 2026
fehmer
commented
Jan 16, 2026
github-actions
bot
added
the
waiting for review
fehmer
force-pushed
the
feature/serve-404-on-missing-assets
branch
from
2f57d55 to
e531d8f
Compare
fehmer
force-pushed
the
feature/serve-404-on-missing-assets
branch
from
e531d8f to
2b39fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firebase will not respond with 404 if any rewrite rule matches.
Now we define only the rewrites that we need like /about etc