Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Enhance Proxy Registration and Prevent Memory Leak #293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alissn
Copy link

@alissn alissn commented Oct 29, 2024

Hi,

In this pull request, I've updated the registration of proxies to preserve user-defined settings in the bootstrap/app.php file.

In the previous version, when custom proxies were defined, they were ignored. The trustProxies method stored its values in the static variable $alwaysTrustProxies and not read form this package middleware.

->trustProxies(at: [
        '92.1.1.1',
     ])

Additionally, before merging values, I ensured that unique proxies are maintained to prevent memory leaks when using the Laravel Octane package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant