test(NODE-6626): implement integration tests for improved client.close() - server-side #4367
+103
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
force-pushed
the
NODE-6626/server-side
branch
2 times, most recently
from
ab9c495 to
34ccf67
Compare
aditi-khare-mongoDB
force-pushed
the
NODE-6626/server-side
branch
from
34ccf67 to
804c464
Compare
| await client.close(); | ||
| await client.connect(); | ||
|
|
||
| // assert clean-up |
There was a problem hiding this comment.
Note: We pass all cases already except cursors already.
There was a problem hiding this comment.
Should the other test cases be unskipped then?
baileympearson
added
the
Primary Review
baileympearson
requested changes
Jan 13, 2025
|
|
||
| it('all active server-side cursors are closed by client.close()', async function () { | ||
| const getCursors = async () => { | ||
| const res = await client |
There was a problem hiding this comment.
optional: this is the sort of thing for which we'd usually use a utilClient. If we use a separate client, we keep the client used for testing separate from the client we use to collect cluster data. It also avoids reopening the client after closing it in the test (line 729).
| await client.close(); | ||
| await client.connect(); | ||
|
|
||
| // assert clean-up |
There was a problem hiding this comment.
Should the other test cases be unskipped then?
| const res = await client | ||
| .db() | ||
| .admin() | ||
| .command({ |
There was a problem hiding this comment.
(optional): Neal added runCursorCommand last year to simplify running cursor commands manually:
const result = await client.db('admin').runCursorCommand({ aggregate: .... }).toArray();
return result.filter(
r => r.type === 'idleCursor' || (r.type === 'op' && r.desc === 'getMore')
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add server-side resource integration tests for client.close(). These tests will remain skipped until improved client.close() is implemented.
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Improved client.close()
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript