chore(NODE-6637): remove drivers tools env setting #4363
+4
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-6637
branch
4 times, most recently
from
1136622 to
7d1a902
Compare
durran
commented
Jan 13, 2025
| @@ -70,7 +70,7 @@ function makeTask({ mongoVersion, topology, tags = [], auth = 'auth' }) { | |||
| name: `test-${mongoVersion}-${topology}${auth === 'noauth' ? '-noauth' : ''}`, | |||
| tags: [mongoVersion, topology, ...tags], | |||
| commands: [ | |||
| updateExpansions({ NPM_VERSION: 9, VERSION: mongoVersion, TOPOLOGY: topology, AUTH: auth }), | |||
| updateExpansions({ VERSION: mongoVersion, TOPOLOGY: topology, AUTH: auth }), | |||
There was a problem hiding this comment.
Removed the NPM_VERSION here just to show in the majority of our tests the fallback script works for all versions.
durran
commented
Jan 13, 2025
| @@ -32,7 +32,7 @@ export PATH="$MONGODB_BINARIES:$PATH" | |||
|
|
|||
| if [ ! -d "$DRIVERS_TOOLS" ]; then | |||
| # Only clone driver tools if it does not exist | |||
| git clone --depth=1 "https://github.com/mongodb-labs/drivers-evergreen-tools.git" "${DRIVERS_TOOLS}" | |||
| git clone --depth=1 --branch NODE-6636 "https://github.com/mongodb-labs/drivers-evergreen-tools.git" "${DRIVERS_TOOLS}" | |||
There was a problem hiding this comment.
Will revert once mongodb-labs/drivers-evergreen-tools#573 merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used the npm setting in based on the environment from drivers tools.
What is changing?
Removes the npm version setting backup from the install script.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6637
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript