-
Notifications
You must be signed in to change notification settings - Fork 75
[LG-5926] refactor(message): remove assistant avatar and name #3482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 807ea76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the assistant avatar and name display from the Message component, simplifying the component by eliminating dependencies on avatar and chat context for assistant identification.
Changes:
- Removed avatar dependency and related imports from the Message component
- Consolidated styling logic by merging message container styles into the main container
- Updated TypeScript configuration to remove avatar package reference
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chat/message/tsconfig.json | Removes avatar package from TypeScript references |
| chat/message/src/Message/Message.tsx | Removes avatar rendering logic, chat context usage, and simplifies JSX structure |
| chat/message/src/Message/Message.styles.ts | Consolidates styling by merging message container styles into base container |
| chat/message/src/Message.stories.tsx | Removes avatar control from Storybook argTypes |
| chat/message/package.json | Removes avatar package dependency |
| .changeset/heavy-clocks-sin.md | Documents breaking change for release |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
Size Change: -333 B (-0.02%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Coverage after merging steph/chat-message-rm-avatar into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||
shaneeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but curious if you had thoughts on holding off on merging to main and instead waiting until my work is complete? The initial message component I'm working on seems to be a replacement for the assistant's name.
✍️ Proposed changes
This PR removes the assistant avatar and name display from the
Messagecomponent.🎟️ Jira ticket: LG-5926
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
isSender={false}) no longer display an avatar or assistant name@leafygreen-ui/avataror theassistantNamefrom chat context