-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-41760 Add transactions page #167
DOCSP-41760 Add transactions page #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy looks good, just some notes on the code sample!
source/examples/generated/TransactionsTest.snippet.transaction.kt
Outdated
Show resolved
Hide resolved
source/examples/generated/TransactionsTest.snippet.transaction.kt
Outdated
Show resolved
Hide resolved
source/examples/generated/TransactionsTest.snippet.transaction.kt
Outdated
Show resolved
Hide resolved
source/examples/generated/TransactionsTest.snippet.transaction.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one last suggestion!
source/examples/generated/TransactionsTest.snippet.data-class.kt
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for docs-kotlin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…760-addTransactionsPage
Tagging @mongodb/dbx-java for technical review 🙇♀️ |
Am I correct that this page doesn't exist yet for the Java sync driver? I was looking to compare the two. |
@jyemin Correct, we're in the process of adding these pages. There are a few PRs for Java-related transactions pages in progress: Then one for Kotin sync will be upcoming. There are some examples of existing Transaction pages for other drivers in the JIRA ticket if that is helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good but wondering whether we should document com.mongodb.kotlin.client.ClientSession#withTransaction
here as well, or if that's going in a different PR.
@jyemin thanks for taking a look! I didn't see One other question I have: once this PR is approved and published, to what version of Kotlin Coroutine should we backport the docs update? The docs versions are upcoming, 5.1, 5.0, 4.11, and 4.10. |
Oh, I thought this was a Kotlin Sync Driver page. Are you sure we don't need some sort of call to
It's up to docs team how far all these pages will be backported. |
Will be working on the Kotlin Sync page soon! There's a call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
* Add transactions page, add language variable, include code snippet for transactions --------- Co-authored-by: Rea Rustagi <[email protected]> Co-authored-by: Brandon Ly <[email protected]> Co-authored-by: rustagir <[email protected]> (cherry picked from commit e0c22ee)
* Add transactions page, add language variable, include code snippet for transactions --------- Co-authored-by: Rea Rustagi <[email protected]> Co-authored-by: Brandon Ly <[email protected]> Co-authored-by: rustagir <[email protected]> (cherry picked from commit e0c22ee)
* Add transactions page, add language variable, include code snippet for transactions --------- Co-authored-by: Rea Rustagi <[email protected]> Co-authored-by: Brandon Ly <[email protected]> Co-authored-by: rustagir <[email protected]> (cherry picked from commit e0c22ee)
* Add transactions page, add language variable, include code snippet for transactions --------- Co-authored-by: Rea Rustagi <[email protected]> Co-authored-by: Brandon Ly <[email protected]> Co-authored-by: rustagir <[email protected]> (cherry picked from commit e0c22ee)
* Add transactions page, add language variable, include code snippet for transactions --------- Co-authored-by: Rea Rustagi <[email protected]> Co-authored-by: Brandon Ly <[email protected]> Co-authored-by: rustagir <[email protected]> (cherry picked from commit e0c22ee)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41760
Staging - https://preview-mongodbstephmarie17.gatsbyjs.io/kotlin/docsp-41760-addTransactionsPage/fundamentals/transactions/
Self-Review Checklist