DOCSP-36217: polymorphic serialization #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmorisi
approved these changes
Jul 1, 2024
Comment on lines
269
to
270
| In this example, you create an interface and two data classes that | ||
| inherit that interface. In the data classes, the ``id`` field is marked |
There was a problem hiding this comment.
Nit
Suggested change
| In this example, you create an interface and two data classes that | |
| inherit that interface. In the data classes, the ``id`` field is marked | |
| The following example creates an interface and two data classes that | |
| inherit that interface. In the data classes, the ``id`` field is marked |
Comment on lines
277
to
282
| Then, you can perform operations with data classes as usual. In the | ||
| following example, you parametrize the collection with the ``Person`` | ||
| interface, but you can perform operations with the polymorphic classes | ||
| ``Teacher`` and ``Student``. When you retrieve documents, the driver | ||
| automatically detects the type based on the discriminator value and | ||
| deserializes them accordingly. |
There was a problem hiding this comment.
Nit (these are based on the way we seem to typically introduce examples, let me know if I'm on the wrong track here).
Suggested change
| Then, you can perform operations with data classes as usual. In the | |
| following example, you parametrize the collection with the ``Person`` | |
| interface, but you can perform operations with the polymorphic classes | |
| ``Teacher`` and ``Student``. When you retrieve documents, the driver | |
| automatically detects the type based on the discriminator value and | |
| deserializes them accordingly. | |
| Then, you can perform operations with data classes as usual. The following | |
| example parametrizes the collection with the ``Person`` | |
| interface and performs operations with the polymorphic classes | |
| ``Teacher`` and ``Student``. When you retrieve documents, the driver | |
| automatically detects the type based on the discriminator value and | |
| deserializes them accordingly. |
rustagir
added a commit
that referenced
this pull request
Jul 10, 2024
* DOCSP-36217: polymorphic serialization * wip * wip * wip * fix error in codectest * MM PR fixes 1 (cherry picked from commit b5a5af9)
|
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-36217
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin/DOCSP-36217-polymorphic/fundamentals/data-formats/serialization/#polymorphic-serialization
Self-Review Checklist