-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-39405: kotlin v5.1 content #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + a few suggestions!
|
||
You can specify Azure IMDS OIDC authentication either by | ||
using a ``MongoCredential`` or specifying your credentials in the connection string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: clarify what this is
using a ``MongoCredential`` or specifying your credentials in the connection string. | |
using a ``MongoCredential`` instance or specifying your credentials in the connection string. |
If your application runs on a Google Compute Engine VM, or otherwise uses the | ||
`GCP Instance Metadata Service <https://cloud.google.com/compute/docs/metadata/querying-metadata>`__, | ||
you can authenticate to MongoDB by using {+driver-short+}'s built-in GCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
you can authenticate to MongoDB by using {+driver-short+}'s built-in GCP | |
you can authenticate to MongoDB by using the {+driver-short+}'s built-in GCP |
|
||
You can specify GCP IMDS OIDC authentication either by | ||
using a ``MongoCredential`` or as part of the connection string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
using a ``MongoCredential`` or as part of the connection string. | |
using a ``MongoCredential`` instance or as part of the connection string. |
on a Linux platform. | ||
|
||
The following sections describe how to use the ``MONGODB-OIDC`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I don't think this needs to be monospaced, based on the other mentions of MONGODB-OIDC, Kerberos, LDAP
The following sections describe how to use the ``MONGODB-OIDC`` | |
The following sections describe how to use the MONGODB-OIDC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a kotlin bug then LGTM
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
* DOCSP-39405: kotlin v5.1 content * NR small fixes * RL tech review comments (cherry picked from commit efd48c9)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-39405
Staging:
Self-Review Checklist