Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-39405: kotlin v5.1 content #161

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Jun 20, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-39405
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + a few suggestions!


You can specify Azure IMDS OIDC authentication either by
using a ``MongoCredential`` or specifying your credentials in the connection string.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: clarify what this is

Suggested change
using a ``MongoCredential`` or specifying your credentials in the connection string.
using a ``MongoCredential`` instance or specifying your credentials in the connection string.

If your application runs on a Google Compute Engine VM, or otherwise uses the
`GCP Instance Metadata Service <https://cloud.google.com/compute/docs/metadata/querying-metadata>`__,
you can authenticate to MongoDB by using {+driver-short+}'s built-in GCP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
you can authenticate to MongoDB by using {+driver-short+}'s built-in GCP
you can authenticate to MongoDB by using the {+driver-short+}'s built-in GCP


You can specify GCP IMDS OIDC authentication either by
using a ``MongoCredential`` or as part of the connection string.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
using a ``MongoCredential`` or as part of the connection string.
using a ``MongoCredential`` instance or as part of the connection string.

on a Linux platform.

The following sections describe how to use the ``MONGODB-OIDC``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I don't think this needs to be monospaced, based on the other mentions of MONGODB-OIDC, Kerberos, LDAP

Suggested change
The following sections describe how to use the ``MONGODB-OIDC``
The following sections describe how to use the MONGODB-OIDC

@rustagir rustagir requested a review from rozza June 20, 2024 20:16
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a kotlin bug then LGTM

examples/src/test/kotlin/EnterpriseAuthTest.kt Outdated Show resolved Hide resolved
examples/src/test/kotlin/EnterpriseAuthTest.kt Outdated Show resolved Hide resolved
@rustagir rustagir merged commit efd48c9 into mongodb:master Jun 28, 2024
4 of 5 checks passed
@docs-builder-bot
Copy link
Collaborator

rustagir added a commit that referenced this pull request Jun 28, 2024
* DOCSP-39405: kotlin v5.1 content

* NR small fixes

* RL tech review comments

(cherry picked from commit efd48c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants