DOCSP-33426: socks5 proxy server #146
Conversation
| - Specifies the TCP port number of the SOCKS5 proxy server. This option | ||
| defaults to ``1080`` when you set ``proxyHost``. |
There was a problem hiding this comment.
I'm a bit confused by the last sentence here. It says it defaults to 1080 "when you set proxyHost" but from the description of proxyHost it seems like proxyHost is required? So does that mean this will always default to 1080?
I think my confusion is that this sentence also implies that there is another default, but doesn't specify it. Could you add some clarification here, or possibly remove the "when you set..." part if that still makes sense
There was a problem hiding this comment.
I think the way it works is that if you set proxyHost but do not set proxyPort, proxyPort defaults to 1080. However, you can set proxyPort manually to whatever you want. If you do not set proxyHost, then there is no default for proxyPort and it also remains unset. I can clear up that wording.
| using the ``applyToSocketSettings()`` builder method when creating a | ||
| ``MongoClientSettings``: |
There was a problem hiding this comment.
S/nit: I think "creating a mongoclientsettings" sounds like incorrect grammar or an incomplete sentence, even though it's technically fine since that's just the name of the instance being created
| using the ``applyToSocketSettings()`` builder method when creating a | |
| ``MongoClientSettings``: | |
| using the ``applyToSocketSettings()`` builder method when creating a | |
| ``MongoClientSettings`` instance: |
|
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
* DOCSP-33426: socks5 proxy server * first pass fixes * JS PR fixes (cherry picked from commit f9ec693)
* DOCSP-33426: socks5 proxy server * first pass fixes * JS PR fixes
* DOCSP-33426: socks5 proxy server * first pass fixes * JS PR fixes
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-33426
Staging:
Self-Review Checklist