DOCSP-33427: split large cs events #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccho-mongodb
approved these changes
Jan 12, 2024
| @@ -136,6 +137,37 @@ internal class ChangeStreamsTest { | |||
|
|
|||
| } | |||
|
|
|||
| // This test is getting ignored because the feature is only enabled for deployments on MongoDB 7.0 | |||
There was a problem hiding this comment.
Suggestion:
No change necessary, but I think this could be stated more concisely:
Suggested change
| // This test is getting ignored because the feature is only enabled for deployments on MongoDB 7.0 | |
| // Ignore annotation added because this function requires a MongoDB 7.0 deployment |
Comment on lines
29
to
31
| connecting to a MongoDB deployment running version 6.0 or later, you can | ||
| configure the events to include the document data before and after the | ||
| change. |
There was a problem hiding this comment.
👍
Alternatively, "When connecting to MongoDB v6.0 or later, ..." but I guess this version makes it consistent to the intro paragraph of Split Large Change Stream Events.
There was a problem hiding this comment.
changed for concision!
| you can use the ``$changeStreamSplitLargeEvent`` aggregation operator to | ||
| split event documents that exceed 16 MB into smaller fragments. | ||
|
|
||
| Use the ``$changeStreamSplitLargeEvent`` operator only when necessary. For |
There was a problem hiding this comment.
Suggestion:
I think it could be helpful to identify the specific condition in this sentence, even though I think I wrote the same thing in the Java docs.
Suggested change
| Use the ``$changeStreamSplitLargeEvent`` operator only when necessary. For | |
| Use the ``$changeStreamSplitLargeEvent`` operator only when you expect | |
| the change stream events to exceed the 16 MB document size limit. For |
| fun splitLargeChangeStreamTest() = runBlocking { | ||
| val changeEvents = mutableListOf<ChangeStreamDocument<Document>>() | ||
| // :snippet-start: split-large-change-stream | ||
| val pipeline = listOf(BsonDocument.parse("{ \$changeStreamSplitLargeEvent: {} }")) |
There was a problem hiding this comment.
Question:
For personal edification, is this way way is more idiomatic than the following:
val pipeline = listOf(BsonDocument().append("$changeStreamSplitLargeEvent", BsonDocument()))
|
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
rustagir
added a commit
that referenced
this pull request
Jan 16, 2024
* DOCSP-33427: split large cs events * CC PR suggestions (cherry picked from commit 9667a4f)
ccho-mongodb
pushed a commit
to ccho-mongodb/docs-kotlin
that referenced
this pull request
Feb 14, 2024
* DOCSP-33427: split large cs events * CC PR suggestions
ccho-mongodb
pushed a commit
to ccho-mongodb/docs-kotlin
that referenced
this pull request
Feb 14, 2024
* DOCSP-33427: split large cs events * CC PR suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-33427
Staging
Self-Review Checklist