Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-33428: vectorsearch builder #143

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Jan 9, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33428
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin/DOCSP-33428-vectorsearch-builder/fundamentals/builders/aggregates/#atlas-vector-search

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one question

Comment on lines 933 to 934
The following example shows how to build an aggregation pipeline that uses the
``vectorSearch()`` and ``project()`` methods to compute a vector search
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we need to show the project() stage in this example? I think it might be more clear to adjust the snippet to only show the Aggregates.vectorSearch stage so it doesn't seem like project is always needed (unless it is always needed). Removing project would also help make this sentence a little shorter and easier to read.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can adjust the example. I can also explain more what the agg stage is actually doing.

@rustagir rustagir merged commit 65f210d into mongodb:master Jan 10, 2024
5 checks passed
@docs-builder-bot
Copy link
Collaborator

rustagir added a commit that referenced this pull request Jan 10, 2024
* DOCSP-33428: vectorsearch builder

* use other data class

* add taxonomy + small fixes

* JS PR fixes - remove projection stage

* fixes

* fixes

(cherry picked from commit 65f210d)
ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Feb 14, 2024
* DOCSP-33428: vectorsearch builder

* use other data class

* add taxonomy + small fixes

* JS PR fixes - remove projection stage

* fixes

* fixes
ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Feb 14, 2024
* DOCSP-33428: vectorsearch builder

* use other data class

* add taxonomy + small fixes

* JS PR fixes - remove projection stage

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants