-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-33428: vectorsearch builder #143
DOCSP-33428: vectorsearch builder #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ one question
The following example shows how to build an aggregation pipeline that uses the | ||
``vectorSearch()`` and ``project()`` methods to compute a vector search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Do we need to show the project()
stage in this example? I think it might be more clear to adjust the snippet to only show the Aggregates.vectorSearch
stage so it doesn't seem like project
is always needed (unless it is always needed). Removing project would also help make this sentence a little shorter and easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can adjust the example. I can also explain more what the agg stage is actually doing.
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
* DOCSP-33428: vectorsearch builder * use other data class * add taxonomy + small fixes * JS PR fixes - remove projection stage * fixes * fixes (cherry picked from commit 65f210d)
* DOCSP-33428: vectorsearch builder * use other data class * add taxonomy + small fixes * JS PR fixes - remove projection stage * fixes * fixes
* DOCSP-33428: vectorsearch builder * use other data class * add taxonomy + small fixes * JS PR fixes - remove projection stage * fixes * fixes
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-33428
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin/DOCSP-33428-vectorsearch-builder/fundamentals/builders/aggregates/#atlas-vector-search
Self-Review Checklist