Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(EAI-616)split test case into more isolated test cases #582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(EAI-616)split test case into more isolated test cases #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 65 additions & 126 deletions packages/mongodb-rag-core/src/contentStore/MongoDbEmbeddedContentStore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,31 @@ jest.setTimeout(30000);
describe("MongoDbEmbeddedContentStore", () => {
let store: MongoDbEmbeddedContentStore | undefined;
let mongod: MongoMemoryReplSet | undefined;
let embeddedContent;
const page: PersistedPage = {
action: "created",
body: "foo",
format: "md",
sourceName: "source1",
metadata: {
tags: [],
},
updated: new Date(),
url: "/x/y/z",
};

const anotherPage: PersistedPage = {
action: "created",
body: "bar",
format: "md",
sourceName: "another-source",
metadata: {
tags: [],
},
updated: new Date(),
url: "/a/b/c",
};
const pages = [page, anotherPage];
beforeEach(async () => {
mongod = await MongoMemoryReplSet.create();
const uri = mongod.getUri();
Expand All @@ -39,46 +64,9 @@ describe("MongoDbEmbeddedContentStore", () => {
embeddingName: OPENAI_RETRIEVAL_EMBEDDING_DEPLOYMENT,
},
});
});

afterEach(async () => {
await store?.drop();
await store?.close();
await mongod?.stop();
});

it("handles embedded content", async () => {
assert(store);

const page: PersistedPage = {
action: "created",
body: "foo",
format: "md",
sourceName: "source1",
metadata: {
tags: [],
},
updated: new Date(),
url: "/x/y/z",
};

const anotherPage: PersistedPage = {
action: "created",
body: "bar",
format: "md",
sourceName: "another-source",
metadata: {
tags: [],
},
updated: new Date(),
url: "/a/b/c",
};

const pages = [page, anotherPage];
for (const page of pages) {
const embeddedContent = await store.loadEmbeddedContent({ page });
embeddedContent = await store.loadEmbeddedContent({ page });
expect(embeddedContent).toStrictEqual([]);

await store.updateEmbeddedContent({
page,
embeddedContent: [
Expand All @@ -94,7 +82,6 @@ describe("MongoDbEmbeddedContentStore", () => {
},
],
});

expect(await store.loadEmbeddedContent({ page })).toMatchObject([
{
embeddings: {
Expand All @@ -106,19 +93,15 @@ describe("MongoDbEmbeddedContentStore", () => {
},
]);
}
});

// Won't find embedded content for some other page
expect(
await store.loadEmbeddedContent({
page: { ...page, sourceName: "source2" },
})
).toStrictEqual([]);
expect(
await store.loadEmbeddedContent({
page: { ...page, url: page.url + "/" },
})
).toStrictEqual([]);
afterEach(async () => {
assert(store);
await store.drop();
await store.close();
await mongod?.stop();
});

it("has an overridable default collection name", async () => {
assert(store);

Expand All @@ -139,87 +122,43 @@ describe("MongoDbEmbeddedContentStore", () => {
"custom-embedded_content"
);
});
it("has an overridable default collection name", async () => {
describe("loadEmbeddedContent", () => {
it("loads embedded content belonging to the page provided", async () => {
assert(store);
const pageEmbeddings = await store.loadEmbeddedContent({ page });
const anotherPageEmbeddings = await store?.loadEmbeddedContent({
page: anotherPage,
});
expect(pageEmbeddings[0].sourceName).toBe(page.sourceName);
expect(anotherPageEmbeddings[0].sourceName).toBe(anotherPage.sourceName);
});
it("does NOT load embedded content for some other page", async () => {
assert(store);
expect(
await store.loadEmbeddedContent({
page: { ...page, sourceName: "source3" },
})
).toStrictEqual([]);
expect(
await store.loadEmbeddedContent({
page: { ...page, url: page.url + "/" },
})
).toStrictEqual([]);
});
});
it("updateEmbeddedContent replaces existing embedded content belonging to the page provided with the new embedded content array provided", async () => {
assert(store);
const originalPageEmbedding = await store.loadEmbeddedContent({ page });
assert(originalPageEmbedding.length === 1);

expect(store.metadata.collectionName).toBe("embedded_content");

const storeWithCustomCollectionName = await makeMongoDbEmbeddedContentStore(
{
connectionUri: MONGODB_CONNECTION_URI,
databaseName: store.metadata.databaseName,
collectionName: "custom-embedded_content",
searchIndex: {
embeddingName: "ada-02",
},
}
);
const newEmbeddings = [{ ...originalPageEmbedding[0], text: "new text" }];
await store.updateEmbeddedContent({ page, embeddedContent: newEmbeddings });

expect(storeWithCustomCollectionName.metadata.collectionName).toBe(
"custom-embedded_content"
);
const pageEmbeddings = await store.loadEmbeddedContent({ page });
expect(pageEmbeddings.length).toBe(1);
expect(pageEmbeddings[0].text).toBe("new text");
});
describe("deleteEmbeddedContent", () => {
let embeddedContent;
const page: PersistedPage = {
action: "created",
body: "foo",
format: "md",
sourceName: "source1",
metadata: {
tags: [],
},
updated: new Date(),
url: "/x/y/z",
};

const anotherPage: PersistedPage = {
action: "created",
body: "bar",
format: "md",
sourceName: "another-source",
metadata: {
tags: [],
},
updated: new Date(),
url: "/a/b/c",
};

const pages = [page, anotherPage];
beforeEach(async () => {
assert(store);
for (const page of pages) {
embeddedContent = await store.loadEmbeddedContent({ page });
expect(embeddedContent).toStrictEqual([]);

await store.updateEmbeddedContent({
page,
embeddedContent: [
{
embeddings: {
[store.metadata.embeddingName]: new Array(1536).fill(0.1),
},
sourceName: page.sourceName,
text: page.body,
url: page.url,
tokenCount: 0,
updated: new Date(),
},
],
});

expect(await store.loadEmbeddedContent({ page })).toMatchObject([
{
embeddings: {
[store.metadata.embeddingName]: expect.any(Array),
},
sourceName: page.sourceName,
text: page.body,
url: page.url,
},
]);
}
});
it("deletes embedded content for a page", async () => {
assert(store);

Expand Down