Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure to verify that only expected MongoDB server warnings are encountered during testing. The implementation tracks server log warnings, allows tests to filter expected warnings, and enforces checks after each test to catch unexpected warnings.
Key changes:
- Added warning tracking and filtering infrastructure to
MongoRunnerSetupclass - Updated
mongodb-runnerdependency from^6.0.0to^6.2.0 - Added
allowWarning()calls throughout test files to filter expected deprecation and operational warnings
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/integration-testing-hooks.ts | Core implementation of warning tracking, filtering, and checkpoint validation |
| packages/shell-api/src/shard.spec.ts | Added warning filters for query analyzer configuration tests |
| packages/shell-api/src/session.spec.ts | Added warning filter for deprecated logout command |
| packages/shell-api/src/replica-set.spec.ts | Added warning filters for replica set operations and query analyzer tests |
| packages/shell-api/src/integration.spec.ts | Added warning filters for multiple deprecated commands and operations |
| packages/e2e-tests/test/e2e.spec.ts | Added warning filters for deprecated commands and improved async handling |
| packages/e2e-tests/test/e2e-proxy.spec.ts | Added warning filter for TLS certificate validation in OIDC tests |
| packages/e2e-tests/test/e2e-oidc.spec.ts | Added warning filter for TLS certificate validation and checkpoint calls |
| packages/e2e-tests/test/e2e-auth.spec.ts | Added warning filter for deprecated logout command |
| packages/cli-repl/src/cli-repl.spec.ts | Added warning filters for deprecated $where operator |
| package.json | Updated mongodb-runner dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.