chore(generative-ai): add url endpoints for compass web usage COMPASS-8376 #6423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Oct 30, 2024
gribnoysup
approved these changes
Oct 31, 2024
Comment on lines
+250
to
+255
| const atlasMetadata = connectionInfo?.atlasMetadata; | ||
| if (!atlasMetadata) { | ||
| throw new Error( | ||
| "Can't perform generative ai request: atlasMetadata is not available" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Small nit: I guess we never expect the requests with the cloud preset to be done when metadata is missing, so maybe this check be moved to the top of the if to make this clearer
…s before connecting, remove extra check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-8376
These endpoints don't exist yet in Atlas, so they may be subject to change a little. I'll open a follow up pr if so. This pr is focuses on making these urls configurable by the consumer of the Atlas AI service (web vs electron).
Ideally these would use the same endpoint, however, as mentioned in a comment in the code, we cannot do UI calls against the admin API at the moment (CLOUDP-251201).
Testing wise we have e2e tests for the endpoints being used in Compass, and existing unit tests. We'll be adding e2e tests for Compass web gen ai in COMPASS-8395. Also a quick manual test worked.