fix(e2e) Port OIDC tests to multiple connections COMPASS-8105 #6063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
changed the title
lerouxb
commented
Jul 29, 2024
lerouxb
commented
Jul 29, 2024
lerouxb
commented
Jul 29, 2024
lerouxb
added
feature flagged
lerouxb
commented
Jul 31, 2024
| authMethod: 'MONGODB-OIDC', | ||
| connectionName: this.test?.fullTitle(), | ||
| connectionName, |
There was a problem hiding this comment.
This was wrong ever since I added it but it is not used for single connections and the tests never executed for multiple connections so we never realised.
lerouxb
commented
Jul 31, 2024
| // we have to browse somewhere that will fire off commands that require | ||
| // authentication so that those commands get rejected due to the expired | ||
| // auth and then that will trigger the confirmation modal we expect. | ||
| await browser.selectConnectionMenuItem( |
There was a problem hiding this comment.
Just to point out again: I still don't know what in the single connection world kicked off a command that requires authentication after 10 seconds which would trigger the re-authorization modal. Somehow it just worked.
lerouxb
commented
Jul 31, 2024
| @@ -22,7 +22,7 @@ export async function hideIndex( | |||
| await browser.screenshot(screenshotName); | |||
| } | |||
|
|
|||
| await browser.clickVisible(Selectors.ConfirmationModalConfirmButton()); | |||
| await browser.clickVisible(Selectors.confirmationModalConfirmButton()); | |||
There was a problem hiding this comment.
drive-by: I cleaned up the naming. It is TitleCase for constants and camelCase for functions.
gribnoysup
approved these changes
Aug 1, 2024
| const modalHeader = await browser.$(`${modal} h1`); | ||
| return (await modalHeader.getText()).includes('Authentication expired'); | ||
| }); | ||
| await browser.pause(10_000); |
There was a problem hiding this comment.
Maybe a comment here that this should aligned with the token expiration or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting mongodb server like this:
(using https://github.com/lerouxb/start-oidc)
This requires the experimental host networking feature enabled for mac and windows which requires signin to docker.
Running with:
Obviously with or without
-- --test-multiple-connectionsand also tweaktest-noserver-nocompileto be eithertest-noserverortest. You probably want a.onlyon the describe too.What this does is it starts the OIDC mock server listening on all ips so that the database server in docker can get to it. It starts it with a known hostname and port so that we can get a consistent, known issuer url to use in the mongodb server config. (38231 was just the last port picked automatically while I was working on this.). It then knows to use that mongodb server rather than start its own.