Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --anonymous-inbound data leak #9632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix --anonymous-inbound data leak #9632

wants to merge 1 commit into from

Conversation

vtnerd
Copy link
Contributor

@vtnerd vtnerd commented Dec 19, 2024

As the title says. Hopefully get some testers to make sure nothing for broken (it is fairly basic).

@vtnerd vtnerd mentioned this pull request Dec 19, 2024
Open
vtnerd
vtnerd commented Dec 19, 2024
View reviewed changes
src/p2p/net_node.inl Outdated Show resolved Hide resolved
@vtnerd vtnerd force-pushed the fix/anonymous_inbound branch from 20dd81b to dc7e3ed Compare December 19, 2024 23:52
@selsta selsta added the daemon label Dec 19, 2024
@vtnerd
Copy link
Contributor Author

vtnerd commented Dec 19, 2024

After "rubber ducking" things, I decided on the following changes from the initial PR:

  • Switch to std::shuffle which is not deprecated, unlike the other shuffle variants
  • Set all last_seen timestamps to 0 when not in public zone.

@vtnerd vtnerd changed the title Fix --anonymouns-inbound data leak Fix --anonymous-inbound data leak Dec 19, 2024
0xFFFC0000
0xFFFC0000 approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

Assignees
No one assigned
Labels
daemon enhancement pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtnerd @0xFFFC0000 @selsta