Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating dataframe with rank and "correct_term" sometimes has (silent) unexpected behavior #52

Open
leokim-l opened this issue Oct 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@leokim-l
Copy link
Member

For example in:
https://github.com/monarch-initiative/pheval.llm/blob/main/out_openAI_models/multimodel/gpt-4o/full_df_results.tsv

Line 1498 (in total in 110 total lines/rows) the correct_term column contains the rank instead of the OMIM. Phenopackets seem fine (although older versions may have had bugs). I suspect this issue to be in some measure in all output we have.

Probably some issue here or somewhere farther below:

label_to_correct_term = answers.set_index("label")["term"].to_dict()

@leokim-l leokim-l added the bug Something isn't working label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants