Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large degree of "undergrouping" in PHENIO/uPheno #46

Open
matentzn opened this issue Oct 23, 2023 · 1 comment
Open

Large degree of "undergrouping" in PHENIO/uPheno #46

matentzn opened this issue Oct 23, 2023 · 1 comment

Comments

@matentzn
Copy link
Member

matentzn commented Oct 23, 2023

From @cmungall

image

the two highlighted terms should converge on external ear morph rather than plain ear morph

@jmcl this is a super high priority uPheno issue for the next months!

@cmungall
Copy link
Member

In this case the problem is with HPO

The logical definition reflects the term label, which disguises an implicit commitment to morphology.

Proposal:

  • HPO label changes to "Abnormal morphology of the outer ear"
  • logical definition also changes

This would reflect the placement in the is-a hierarchy:

image

It could be argued that this should be obvious: unlike with say the inner ear, there is no physiology to be confused with the outer ear. But even if the label remains the same the logical definition should change

https://www.ebi.ac.uk/ols4/ontologies/hp/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FHP_0000356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants