Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated classes: to include or not to include? #45

Open
matentzn opened this issue Nov 30, 2023 · 0 comments
Open

Deprecated classes: to include or not to include? #45

matentzn opened this issue Nov 30, 2023 · 0 comments
Assignees

Comments

@matentzn
Copy link
Member

There is a big questionmark around deprecated classes. We can either include or ignore them. Right now, the mondo.sssom.tsv still contains them (see for example this PR).

@kevinschaper what is your sense?

  1. Case 1: Mondo class is deprecated, external (eg OMIM) class is not
  2. Case 2: Mondo and external class is deprecated
  3. Case 3: Mondo is not deprecated, but external one is

For our use cases, I think its obvious that 3 will be included.

  1. Is tougher. I personally think this helps with transparency.
  2. No idea. What if a datasource uses an OMIM class that is deprecated without replacement, Mondo also decided to deprecate it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants