fix rate limit, adds de-duplication of teams #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
pkg/sync/sync.go:91
- The variable name 'target_handle' should be renamed to 'targetHandle' to follow Go naming conventions.
target_handle, err := getTargetHandle(os.Getenv("GHMT_MAPPING_FILE"), member.Login)
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling of GitHub API rate limits and optimize the process of fetching repository teams by avoiding duplicate entries.
Rate Limit Handling:
internal/api/api.go: Updated the context inGetRepositoryTeamsto include a value that ensures the client sleeps until the primary rate limit is reset when rate limited.Team Synchronization Optimization:
pkg/sync/sync.go: Introduced a map to track added teams inSyncTeamsByRepoto avoid adding duplicate teams to the list.