remove authenticated user if not part of membership #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update spinner text to know which team is getting processed
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (1)
internal/api/api.go:397
- The comment should start with a capital letter: 'Get authenticated user'.
// Get authenticated user
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
antgrutta
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces adding functions to get the authenticated user and remove a team member, and updating the team creation logic to ensure the authenticated user is correctly managed.
The authenticated user that creates the team gets automatically added to the team. However, that is most likely not the desired outcome. This functionality removes the authenticated user from the team if they are not part of the source team members.
New functionalities:
internal/api/api.go: AddedGetAuthenticatedUserfunction to retrieve the authenticated user andRemoveTeamMemberfunction to remove a team member by slug.Enhancements to team synchronization:
internal/team/team.go: UpdatedCreateTeammethod to retrieve the authenticated user, check if they are part of the team members, and remove them if they are not.pkg/sync/sync.go: ImprovedSyncTeamsByRepofunction to update the spinner text with the team name during the team creation process.