Merge pull request #18 from mon-petit-placement/fix/allowed-values

fix: types errors
mon-petit-placement · Oct 4, 2023 · 28a90ab · 28a90ab
2 parents 58adf95 + 9e41702
commit 28a90ab
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 5 deletions.
diff --git a/Model/Document.php b/Model/Document.php
@@ -44,7 +44,7 @@ public function __construct()
         $this->content = null;
         $this->url = null;
         $this->fileName = null;
-        $this->signatureFields = null;
+        $this->signatureFields = [];
         $this->checkBoxTexts = null;
         $this->metaData = null;
         $this->title = null;

diff --git a/Model/Signer.php b/Model/Signer.php
@@ -105,7 +105,7 @@ public static function configureData(OptionsResolver $resolver): void
                 return RegistrationRequest::createFromArray($value);
             })
             ->setDefault('validationSessionId', null)->setAllowedTypes('validationSessionId', ['null', 'string'])
-            ->setDefault('redirectPolicy', null)->setAllowedValues('redirectPolicy', ['null', 'dashboard', 'quick'])
+            ->setDefault('redirectPolicy', null)->setAllowedValues('redirectPolicy', [null, 'dashboard', 'quick'])
             ->setDefault('redirectWait', 5)->setAllowedTypes('redirectWait', ['int'])->setNormalizer('redirectWait', function (Options $options, $value) {
                 if ('quick' === $options['redirectPolicy']) {
                     return null;

diff --git a/Model/TransactionInfo.php b/Model/TransactionInfo.php
@@ -32,7 +32,7 @@ class TransactionInfo
 
     protected ?string $description;
 
-    protected InitiatorInfo $initiatorInfo;
+    protected ?InitiatorInfo $initiatorInfo;
 
     protected ?bool $eachField;
 

diff --git a/Requester/RegistrationAuthority.php b/Requester/RegistrationAuthority.php
@@ -6,7 +6,6 @@
 use Mpp\UniversignBundle\Model\MatchingResult;
 use Mpp\UniversignBundle\Model\ValidationRequest;
 use Mpp\UniversignBundle\Model\ValidatorResult;
-use PhpXmlRpc\Encoder;
 use PhpXmlRpc\Exception;
 use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Routing\Router;

diff --git a/Requester/Signer.php b/Requester/Signer.php
@@ -10,7 +10,6 @@
 use Mpp\UniversignBundle\Model\TransactionRequest;
 use Mpp\UniversignBundle\Model\TransactionResponse;
 use Mpp\UniversignBundle\Model\XmlRpc\Base64;
-use PhpXmlRpc\Encoder;
 use PhpXmlRpc\Exception;
 use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Routing\Router;