fix(TextInput): make label and clearAriaLabel required and provide options for autoComplete prop #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccarrington
added
the
validated
dominiccarrington
force-pushed
the
fix/a11y/TextInput-types
branch
from
65f4b13
to
815c32d
Compare
gabrielchl
reviewed
Nov 27, 2024
…ide options for autoComplete
Co-authored-by: Gabriel Lee <[email protected]>
dominiccarrington
force-pushed
the
fix/a11y/TextInput-types
branch
from
0609db2
to
abca219
Compare
| | 'tel-extension' | ||
| | 'email' | ||
| | 'impp' | ||
| | (string & Record<never, never>); |
There was a problem hiding this comment.
This is to prevent type overreach.
If it was just string, we wouldn't get any autocomplete help since all the above would be merged into just string.
gabrielchl
approved these changes
Nov 28, 2024
|
🎉 This PR is included in version 26.180.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following: