Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024b #1120

Closed
wants to merge 1 commit into from
Closed

Add 2024b #1120

wants to merge 1 commit into from

Conversation

er0k
Copy link

@er0k er0k commented Oct 3, 2024

I realize contributor PRs to update the data are generally not accepted, but here is one anyway, just in case 🙂

closes #1119

Copy link

linux-foundation-easycla bot commented Oct 3, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@gilmoreorless
Copy link
Member

Thanks for the prompt for me to fix the automated builds. 😄

The reason we don't currently accept contributor PRs for data updates isn't anything personal, it's simply about having a standardised build environment. The data build process (for better or worse) relies on the binaries zic and zdump, which can vary wildly between platforms. Our CI process actually builds those binaries from scratch using the source code of the matching IANA release, guaranteeing compatibility.

As an example, this PR is very close to the automated #1121, but there are some subtle bugs that were introduced (presumably by an ever so slightly out-of-date zic and/or zdump). In this PR, the zones America/Godthab, America/Nuuk, America/Scoresbysund, Asia/Gaza and Asia/Hebron contain data changes that shouldn't be there. This is a problem that I've seen only on recent versions of macOS, due to the specific versions of the provided binaries (see #1085 for a full description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024b
2 participants