-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #727
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there!
- Double check all testmode parameters: typing (also on docblocks)
- Double check all testmode parameters: presence. I.e. mandate.revokeForCustomerId vs mandate.revokeForCustomer.
I am now going to spin up a test/demo environment.
@@ -0,0 +1,26 @@ | |||
# Responses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks outdated after our last discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? It s only stating what we discussed. By default all responses are hydrated.
* | ||
* @throws ApiException | ||
*/ | ||
public function update(string $id, $data = []): ?Customer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking on the Mollie Slack if the testmode parameter is intentionally omitted from the docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sort of sense because the id already points to a specific entry but it’s not the standard for other endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly
UPGRADING.md is still in progress
Some Context...
..on how the new request cycle works