Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 #727

Open
wants to merge 202 commits into
base: master
Choose a base branch
from
Open

V3 #727

wants to merge 202 commits into from

Conversation

Naoray
Copy link
Collaborator

@Naoray Naoray commented Jun 24, 2024

UPGRADING.md is still in progress


Some Context...

..on how the new request cycle works
Screenshot 2024-09-09 at 11 03 17

@Naoray Naoray requested a review from sandervanhooft June 24, 2024 22:34
@Naoray Naoray requested a review from sandervanhooft January 16, 2025 00:01
Copy link
Collaborator

@sandervanhooft sandervanhooft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there!

  • Double check all testmode parameters: typing (also on docblocks)
  • Double check all testmode parameters: presence. I.e. mandate.revokeForCustomerId vs mandate.revokeForCustomer.

I am now going to spin up a test/demo environment.

docs/debugging.md Show resolved Hide resolved
docs/http-adapters.md Outdated Show resolved Hide resolved
.github/workflows/create_scoped_zip.yml Show resolved Hide resolved
.github/workflows/create_scoped_zip.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
UPGRADING.md Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@@ -0,0 +1,26 @@
# Responses
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks outdated after our last discussion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It s only stating what we discussed. By default all responses are hydrated.

*
* @throws ApiException
*/
public function update(string $id, $data = []): ?Customer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking on the Mollie Slack if the testmode parameter is intentionally omitted from the docs here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sort of sense because the id already points to a specific entry but it’s not the standard for other endpoints

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants