Add MCP tool annotations support #2
Open
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3flex
force-pushed
the
feat/tool_annotations
branch
from
24e4818 to
52453f9
Compare
d3flex
added a commit
to d3flex/openQA
that referenced
this pull request
Jan 13, 2026
This reverts commit 9f68de6. Depends-on: mojolicious/mojo-mcp#2
Martchus
reviewed
Jan 13, 2026
Martchus
left a comment
Martchus
left a comment
There was a problem hiding this comment.
Take my review with a grain of Salt as I don't really know the mojo-mcp project.
lib/MCP/Server.pm
Outdated
|
|
||
| # Only include annotations if at least one field is set | ||
| my $annotations = $tool->annotations; | ||
| $info->{annotations} = $annotations if %$annotations; |
There was a problem hiding this comment.
Suggested change
| $info->{annotations} = $annotations if %$annotations; | |
| $info->{annotations} = $annotations if keys %$annotations; |
lib/MCP/Tool.pm
Outdated
Comment on lines
116
to
117
| Optional annotations for the tool which provide additional metadata about tool | ||
| behavior. |
There was a problem hiding this comment.
Suggested change
| Optional annotations for the tool which provide additional metadata about tool | |
| behavior. | |
| Optional annotations for the tool which provide additional metadata about the | |
| tool behavior. |
Comment on lines
+114
to
+117
| ok !exists $tool->{annotations}{readOnlyHint}, 'no readOnlyHint'; | ||
| ok !exists $tool->{annotations}{destructiveHint}, 'no destructiveHint'; | ||
| ok !exists $tool->{annotations}{idempotentHint}, 'no idempotentHint'; | ||
| ok !exists $tool->{annotations}{openWorldHint}, 'no openWorldHint'; |
There was a problem hiding this comment.
This should probably verify that these hints are serialized as boolean (and not e.g. as number).
Author
There was a problem hiding this comment.
The think is that it serializes only the fields that are set. So there is nothing as boolean here.
ok 2 - has title annotation
$VAR1 = {
'title' => 'Server Information'
};
Unless you are talking about the Full annotations subtest?
There was a problem hiding this comment.
Oh, right. Then I guess this remark still counts for the Full annotations subtest.
d3flex
force-pushed
the
feat/tool_annotations
branch
from
52453f9 to
5587abe
Compare
Implement per MCP specification: https://modelcontextprotocol.io/specification/draft/schema#toolannotations adding annotations attribute to MCP::Tool related_issue: https://progress.opensuse.org/issues/193555 Signed-off-by: Ioannis Bonatakis <[email protected]>
d3flex
force-pushed
the
feat/tool_annotations
branch
from
5587abe to
5a9047f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement per MCP specification:
https://modelcontextprotocol.io/specification/draft/schema#toolannotations adding annotations attribute to MCP::Tool
related_issue: https://progress.opensuse.org/issues/193555