Update to Node 18 (#298)

Update most dependencies, including discord.js and ESLint
Also minor fixes to the GitHub workflow

.github/workflows/pull-request-build.yml

@@ -11,18 +11,19 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v3
 
-    - name: Setup Node.js ${{ matrix.node-version }}
+    - name: Set up Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node-version }}
 
-    - uses: actions/cache@v3
+    - name: Set up cache for NPM modules
+      uses: actions/cache@v3
       with:
         path: ~/.npm
         key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

.github/workflows/push-build-deploy.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
 
     steps:
     - name: Checkout repository
@@ -60,8 +60,8 @@ jobs:
         artifact_paths: |
           bin
           node_modules
-          config/default.yml
-          config/main.yml
+          config/default.*
+          config/main.*
           *.sh
         artifact_destination: /home/mojiradiscordbot/mojira-discord-bot
         script: |

eslint.config.mjs

@@ -0,0 +1,115 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import stylistic from "@stylistic/eslint-plugin";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [{
+    ignores: [
+        // don't ever lint node_modules
+        "**/node_modules",
+        // don't lint build output (make sure it's set to your correct build folder name)
+        "**/bin"
+    ],
+}, ...compat.extends("eslint:recommended", "plugin:@typescript-eslint/recommended"), {
+    files: ["**/*.ts"],
+
+    plugins: {
+        "@typescript-eslint": typescriptEslint,
+        "@stylistic": stylistic,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.node,
+        },
+
+        parser: tsParser,
+        ecmaVersion: 5,
+        sourceType: "module",
+
+        parserOptions: {
+            project: "tsconfig.json",
+        },
+    },
+
+    rules: {
+        "brace-style": ["warn", "1tbs", {
+            allowSingleLine: true,
+        }],
+
+        "comma-dangle": ["warn", "always-multiline"],
+        "comma-spacing": "warn",
+        "comma-style": "warn",
+        curly: ["warn", "multi-line", "consistent"],
+        "dot-location": ["warn", "property"],
+        "eol-last": "warn",
+        "@stylistic/indent": ["warn", "tab"],
+        "keyword-spacing": ["warn"],
+
+        "max-nested-callbacks": ["warn", {
+            max: 4,
+        }],
+
+        "max-statements-per-line": ["warn", {
+            max: 2,
+        }],
+
+        "no-empty-function": "warn",
+        "no-floating-decimal": "warn",
+        "@typescript-eslint/no-floating-promises": "error",
+        "no-inline-comments": "warn",
+        "no-lonely-if": "warn",
+        "no-multi-spaces": "warn",
+
+        "no-multiple-empty-lines": ["warn", {
+            max: 2,
+            maxEOF: 1,
+            maxBOF: 0,
+        }],
+
+        "no-shadow": "off",
+
+        "@typescript-eslint/no-shadow": ["error", {
+            allow: ["err", "resolve", "reject"],
+        }],
+
+        "no-trailing-spaces": ["warn"],
+        "no-var": "error",
+        "object-curly-spacing": ["warn", "always"],
+        "prefer-const": "error",
+        quotes: ["warn", "single"],
+        "@stylistic/semi": ["warn"],
+        "space-before-blocks": "warn",
+
+        "space-before-function-paren": ["warn", {
+            anonymous: "never",
+            named: "never",
+            asyncArrow: "always",
+        }],
+
+        "space-in-parens": ["warn", "always", {
+            exceptions: ["empty"],
+        }],
+
+        "space-infix-ops": "warn",
+        "space-unary-ops": "warn",
+        "spaced-comment": "warn",
+        "template-curly-spacing": ["warn", "always"],
+
+        yoda: ["error", "never", {
+            exceptRange: true,
+        }],
+    },
+}];