feat: add inbound metrics pi27 clean #610
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
What have I done?
-> I have modified the following files
src/index.js -> Just added metrics argument in the functions
src/InboundServer/index.js -> Same! Added metrics in the functions' parameters
InboundTransferModel.test.js file -> Introduced metricsClient where it was missing
InboundTransferModel.js file,
TestServer.js file
Here, I have made some major changes. Maybe.
expect(inboundServer._api._cache.set).toHaveBeenCalledTimes(4);
TOexpect(inboundServer._api._cache.set).toHaveBeenCalled();
and
The change
All test cases in p2p_happy_path.json are passing.
Test Cases
Inbound
Outbound
What is expected?
-> Issue -> mojaloop/project#4114